Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support org_name and job price info sent by API #2404

Merged
merged 6 commits into from
Nov 3, 2021

Conversation

YevheniiSemendiak
Copy link
Contributor

Closes #2401

Diff summary:

  • SDK:
    • added optional org_name field to JobDescription (sending to API and parsing the response)
    • added mandatory total_price_credits and price_credits_per_hour fields sent by API
  • CLI:
    • optionally ( if got from API ) show org_name JobStatusFormatter
    • show Price (credits / hour) = price_credits_per_hour in JobStatusFormatter (FR by Synthesis)
    • show Current cost = total_price_credits in JobStatusFormatter (FR by Synthesis)

@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #2404 (8939693) into master (bf587e1) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 8939693 differs from pull request most recent head b5e1e75. Consider uploading reports for the commit b5e1e75 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2404      +/-   ##
==========================================
+ Coverage   71.51%   71.55%   +0.04%     
==========================================
  Files          67       67              
  Lines       11744    11757      +13     
  Branches     1787     1789       +2     
==========================================
+ Hits         8399     8413      +14     
  Misses       3073     3073              
+ Partials      272      271       -1     
Impacted Files Coverage Δ
neuro-cli/src/neuro_cli/formatters/jobs.py 73.25% <100.00%> (+0.18%) ⬆️
neuro-sdk/src/neuro_sdk/jobs.py 80.85% <100.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf587e1...b5e1e75. Read the comment docs.

@YevheniiSemendiak YevheniiSemendiak merged commit 5ff1f8b into master Nov 3, 2021
@YevheniiSemendiak YevheniiSemendiak deleted the ys/extend_job_description branch November 3, 2021 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose reports-related fields in platform_api /jobs endpoint into the SDK
2 participants